Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused env var VESPA_MBUS_DOCUMENTAPI_USE_PROTOBUF #4202

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Remove unused env var VESPA_MBUS_DOCUMENTAPI_USE_PROTOBUF #4202

merged 1 commit into from
Sep 18, 2024
+0 −1

Conversation

hmusum
Copy link
Member

@hmusum hmusum commented Sep 18, 2024

Seems like this is not used anymore

vekterli
vekterli approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@vekterli vekterli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 indeed, this was used prior to finalizing the protocol negotiation for the new protobuf implementation

@hmusum hmusum merged commit 5c43f7d into master Sep 18, 2024
2 checks passed
@hmusum hmusum deleted the hmusum/remove-unused-environment-variable branch September 18, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vekterli vekterli vekterli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmusum @vekterli