Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw features collector. #32435

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Add raw features collector. #32435

merged 2 commits into from
Sep 20, 2024

Conversation

toregge
Copy link
Member

@toregge toregge commented Sep 19, 2024

@geirst : please review

@toregge toregge requested a review from geirst September 19, 2024 15:11
geirst
geirst previously approved these changes Sep 20, 2024
Copy link
Member

@geirst geirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


namespace search::bitcompression {

class RawFeaturesCollector {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add class comment describing what this class is used for.

@geirst geirst merged commit aa97ef2 into master Sep 20, 2024
3 checks passed
@geirst geirst deleted the toregge/add-raw-features-collector branch September 20, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants