RSDK-6884 - Change StartMappingSessionRequest in cloud_slam.proto #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkufieta
changed the title
JohnN193
approved these changes
Mar 11, 2024
JohnN193
approved these changes
Mar 11, 2024
kkufieta
commented
Mar 13, 2024
Comment on lines
+35
to
+41
| Module module = 12; | ||
| } | ||
|
|
||
| message Module { | ||
| string name = 2; | ||
| string module_id = 3; | ||
| string version = 4; |
There was a problem hiding this comment.
@randhid Should this be embedded in StartMappingSessionRequest given that we're not re-using Module?
i.e.
message StartMappingSessionRequest {
...
string existing_map_version = 11;
string module_name = 12;
string module_id = 13;
string module_version = 14;
}There was a problem hiding this comment.
i think its reasonable to leave outside the request, because other cloud features will inevitably use their own registry modules
There was a problem hiding this comment.
It's reasonable as is. It's interestign to note that we are first classing modules for cloud slam right now since this si required. But that's okay.
randhid
approved these changes
Mar 14, 2024
kkufieta
force-pushed
the
kk/cloud-slam-enable-modules
branch
from
431ab0d to
ba40a10
Compare
JohnN193
approved these changes
Mar 15, 2024
Simberific
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://viam.atlassian.net/browse/RSDK-6884
Done (in
StartMappingSessionRequest):slam_algorithm_params-->slam_configModule moduleWon't merge until App is approved: