Skip to content

[APP 5317]: add who field to robot part history entry #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jgeaso1266
Copy link
Contributor

@jgeaso1266 jgeaso1266 commented Jun 21, 2024

Related PRs and Docs

APP-5261, 5262, 5263
Scope doc

Description

This PR simply adds a "who" field to the RobotPartHistoryEntry struct. In doing this, it also creates a AuthenticatorInfo struct and an AuthenticationType enum. See related PR for more info.

agavram and others added 2 commits June 20, 2024 19:57
@CLAassistant
Copy link

CLAassistant commented Jun 21, 2024

CLA assistant check
All committers have signed the CLA.

@jgeaso1266 jgeaso1266 requested a review from anjinai June 21, 2024 15:04
@github-actions github-actions bot added the safe to test committer is a member of this org label Jun 21, 2024
@jgeaso1266 jgeaso1266 changed the title [APP 5317]: be add who field to robot part history entry [APP 5317]: add who field to robot part history entry Jun 21, 2024
@jgeaso1266 jgeaso1266 added the ready-for-protos add this when you want protos to compile on every commit label Jun 21, 2024
@agavram agavram marked this pull request as ready for review June 24, 2024 21:16
@jgeaso1266 jgeaso1266 removed request for jr22 and anjinai June 25, 2024 14:05
@agavram agavram removed the ready-for-protos add this when you want protos to compile on every commit label Jun 25, 2024
@agavram agavram merged commit ae8112d into viamrobotics:main Jun 25, 2024
@agavram agavram deleted the APP-5317-BE-Add-who-field-to-RobotPartHistoryEntry branch June 25, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protos-compiled safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants