DATA-3911 Updates to DataPipeline protos #652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0nick
added
ready-for-protos
katiepeters
reviewed
Mar 19, 2025
proto/viam/app/data/v1/data.proto
Outdated
| @@ -593,8 +593,8 @@ message DataPipeline { | |||
| // each document is one stage in the pipeline. | |||
| repeated bytes mql_binary = 4; | |||
|
|
|||
| // A cron expression representing the expected execution schedule (note this also defines | |||
| // the input time window; an hourly schedule would process 1 hour of data at a time). | |||
| // A cron expression representing the expected execution schedule, in UTC (note this also | |||
There was a problem hiding this comment.
The comma doesn't make sense here
katiepeters
approved these changes
Mar 19, 2025
n0nick
removed
the
ready-for-protos
n0nick
changed the title
n0nick
added
the
ready-for-protos
n0nick
removed
the
ready-for-protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.