Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-7877 Add fragment fragments endpoint #667

Merged
merged 3 commits into from
Apr 7, 2025
Merged

APP-7877 Add fragment fragments endpoint #667

merged 3 commits into from
Apr 7, 2025

Conversation

ehhong
Copy link
Member

@ehhong ehhong commented Apr 4, 2025 •
edited
Loading

Adds listFragmentNestedFragments endpoint to support fragment builder page -- parallel to listMachineFragments.
Review changes in app.proto only.

@github-actions github-actions bot added the safe to test committer is a member of this org label Apr 4, 2025
@ehhong ehhong requested review from DTCurrie and mcous April 7, 2025 16:32
DTCurrie
DTCurrie approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@DTCurrie DTCurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we bump connect-es or something? Looks like a bunch of unrelated changes in the gen code. LGTM otherwise. Maybe the rpc could be called ListNestedFragments for brevity? But I am assuming that was already considered/discussed.

mcous
mcous approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ehhong
Copy link
Member Author

ehhong commented Apr 7, 2025

Did we bump connect-es or something? Looks like a bunch of unrelated changes in the gen code. LGTM otherwise. Maybe the rpc could be called ListNestedFragments for brevity? But I am assuming that was already considered/discussed.

@DTCurrie will regenerate the code. name was not discussed and i don't love the current name so will use ListNestedFragments -- thanks!

@ehhong ehhong force-pushed the APP-7877/ehhong/list-fragments-endpoint branch from 9503cf8 to aefc83b Compare April 7, 2025 17:35
@ehhong ehhong added the ready-for-protos add this when you want protos to compile on every commit label Apr 7, 2025
@ehhong ehhong removed the ready-for-protos add this when you want protos to compile on every commit label Apr 7, 2025
@ehhong ehhong merged commit 24d8d89 into main Apr 7, 2025
3 checks passed
@ehhong ehhong mentioned this pull request Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DTCurrie DTCurrie DTCurrie approved these changes

@mcous mcous mcous approved these changes

Assignees
No one assigned
Labels
protos-compiled safe to test committer is a member of this org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehhong @DTCurrie @mcous