Update cloud action to allow platform specific builds #3377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to build
npentrel
force-pushed
the
build-action-only
branch
from
b8a9578 to
1262e02
Compare
npentrel
force-pushed
the
build-action-only
branch
from
1262e02 to
f60a329
Compare
|
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3377 |
|
Thanks for reaching out. Its currently not supported. The meta.json schema that the CLI reads is in https://github.com/viamrobotics/rdk/blob/main/cli/module_registry.go#L63. We have discussed making platform specific build fields but it hasn't been implemented yet. For now developers can accomplish this by having platform checks within build scripts. For example: https://github.com/michaellee1019/prusa-connect-camera-server/blob/main/build.sh#L4 |
|
ok, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michaellee1019 Did we ever end up implementing platform specific builds? I noticed some commented out docs for this.