Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3130: Add MoveThroughJointPositions method to arm interface #3692

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

JessamyT
Copy link
Collaborator

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Nov 19, 2024
@viambot
Copy link
Member

viambot commented Nov 19, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3692

Copy link
Contributor

@sguequierre sguequierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for making a changelog entry! Did you check the SDKs too to see what content will be pulled in and if it could be improved?

@JessamyT
Copy link
Collaborator Author

Yep I checked the SDKs and it seems only Go has implemented it so far (as reflected in the CSV), and does have an example, but I just noticed the example is mis-labeled there so fixing here viamrobotics/rdk#4575

@JessamyT
Copy link
Collaborator Author

@npentrel I figure the link to the method details can be changed once the automation creates something to change the link to. Would you rather I not add this to the changelog until then though?

@JessamyT JessamyT merged commit c5f2159 into viamrobotics:main Nov 21, 2024
10 checks passed
@JessamyT JessamyT deleted the 3130movethru branch November 21, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants