DOCS-3423: Update training script to parse labels based on feedback from etai/tahiya #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to build
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sguequierre
commented
Jan 29, 2025
sguequierre
commented
Jan 29, 2025
sguequierre
commented
Jan 29, 2025
|
|
||
|
|
||
| # This is used for parsing the dataset file (produced and stored in Viam), | ||
| # parse it to get the label annotations | ||
| # Used for training classifiction models | ||
|
|
||
|
|
There was a problem hiding this comment.
flake8 parser was complaining about this
sguequierre
commented
Jan 29, 2025
|
|
||
| # Save labels.txt file | ||
| save_labels(LABELS + [unknown_label], MODEL_DIR) | ||
| # Convert the model to tflite | ||
| save_model( | ||
| model, MODEL_DIR, "classification_model", IMG_SIZE + (3,) | ||
| model, MODEL_DIR, "classification_model" |
There was a problem hiding this comment.
correction, was never being used
vpandiarajan20
approved these changes
Jan 29, 2025
sguequierre
commented
Jan 29, 2025
|
|
||
| # This parses the required args for the training script. | ||
| # The model_dir variable will contain the output directory where | ||
| # the ML model that this script creates should be stored. | ||
| # The data_json variable will contain the metadata for the dataset | ||
| # that you should use to train the model. | ||
|
|
||
|
|
There was a problem hiding this comment.
know this is awk but python markdown parser was complaining about this specifically
npentrel
reviewed
Feb 3, 2025
npentrel
reviewed
Feb 3, 2025
npentrel
reviewed
Feb 3, 2025
npentrel
reviewed
Feb 3, 2025
docs/data-ai/ai/train.md
Outdated
| @@ -90,15 +88,17 @@ If you haven't already, create a folder called <file>model</file> and create an | |||
|
|
|||
| <p><strong>4. Add <code>training.py</code> code</strong></p> | |||
|
|
|||
| <p>Copy this template into <file>training.py</file>:</p> | |||
| <p>Copy one of the following templates into <file>training.py</file>, depending on whether or not you wish to parse labels:</p> | |||
There was a problem hiding this comment.
Can you rephrase this to have the condition based on which the reader should decide be clearer? Why would a user need to use the labels flag or not?
npentrel
requested changes
Feb 3, 2025
sguequierre
commented
Feb 5, 2025
Co-authored-by: Naomi Pentrel <[email protected]>
sguequierre
commented
Feb 5, 2025
sguequierre
commented
Feb 5, 2025
npentrel
reviewed
Feb 6, 2025
npentrel
reviewed
Feb 6, 2025
npentrel
reviewed
Feb 6, 2025
Co-authored-by: Naomi Pentrel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual testing notes: