Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3488: Add tunnel command to CLI #3974

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Feb 6, 2025

@npentrel npentrel requested a review from cheukt February 6, 2025 12:23
@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 793d784
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67a4f52c02698700085406a9
😎 Deploy Preview https://deploy-preview-3974--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 1297 to 1298
| `--desination-port` | The port on a machine part to tunnel to. Default: `0`. | `part tunnel` | Optional |
| `--local-port` | The local port from which to tunnel. Default: `0`. | `part tunnel` | Optional |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are required

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@npentrel npentrel requested a review from cheukt February 6, 2025 16:03
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a suggestion

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Cheuk <[email protected]>
@viambot
Copy link
Member

viambot commented Feb 6, 2025

It looks like the following files may have been renamed. Please ensure you set all needed aliases:
rename docs/manage/software/{deploy-software.md => deploy-packages.md} (26%) rename docs/manage/software/{update-software.md => update-packages.md} (72%)

@npentrel npentrel merged commit eb8be87 into viamrobotics:main Feb 6, 2025
12 checks passed
@npentrel npentrel deleted the DOCS-3488 branch February 6, 2025 17:56
Copy link

github-actions bot commented Feb 6, 2025

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants