-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-3497: Update deploy software #3980
Conversation
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are helpful in tying it together, @npentrel .
I still have a little bit of a concern, which is that in some cases folks will manage OTA software updates to a single machine not using fragments and not using modules with control logic - its unclear if we are trying to cover that use-case, but the title of the page does make it sound somewhat all-encompassing?
@@ -189,18 +190,18 @@ Your module will now be built, packaged and pushed to the Viam Registry. | |||
## Create a fragment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on the exact line here but line 172 has a typo - says "detectio-dock" (missing an n)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise this is a very good update. 👍
Co-authored-by: Matt Vella <[email protected]> Co-authored-by: Nick Hehr <[email protected]>
Thanks @mcvella and @HipsterBrown - I will merge for now and split the control logic into it's own page in https://viam.atlassian.net/browse/DOCS-3584 |
🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)' |
@mcvella & @HipsterBrown thanks for the feedback so far - would you mind reviewing the changes to https://deploy-preview-3980--viam-docs.netlify.app/manage/software/deploy-software/ and see if this addresses your feedback? It's not a lot of changes but it may be enough to do the trick. If either of you have 10 min to chat through this and would prefer that, let me know.