Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3497: Update deploy software #3980

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Feb 7, 2025

@mcvella & @HipsterBrown thanks for the feedback so far - would you mind reviewing the changes to https://deploy-preview-3980--viam-docs.netlify.app/manage/software/deploy-software/ and see if this addresses your feedback? It's not a lot of changes but it may be enough to do the trick. If either of you have 10 min to chat through this and would prefer that, let me know.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Feb 7, 2025
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 548583f
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67adf18367e46f00088b3be5
😎 Deploy Preview https://deploy-preview-3980--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mcvella mcvella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are helpful in tying it together, @npentrel .
I still have a little bit of a concern, which is that in some cases folks will manage OTA software updates to a single machine not using fragments and not using modules with control logic - its unclear if we are trying to cover that use-case, but the title of the page does make it sound somewhat all-encompassing?

docs/manage/software/deploy-software.md Outdated Show resolved Hide resolved
@@ -189,18 +190,18 @@ Your module will now be built, packaged and pushed to the Viam Registry.
## Create a fragment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the exact line here but line 172 has a typo - says "detectio-dock" (missing an n)

Copy link
Contributor

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise this is a very good update. 👍

docs/manage/software/deploy-software.md Outdated Show resolved Hide resolved
@npentrel
Copy link
Collaborator Author

Thanks @mcvella and @HipsterBrown - I will merge for now and split the control logic into it's own page in https://viam.atlassian.net/browse/DOCS-3584

@npentrel npentrel merged commit 2239b1b into viamrobotics:main Feb 13, 2025
12 checks passed
@npentrel npentrel deleted the DOCS-3497 branch February 13, 2025 13:23
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants