Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-3398: Add data client flutter methods to automation #3983

Merged
merged 5 commits into from
Feb 13, 2025
Merged

DOCS-3398: Add data client flutter methods to automation #3983

merged 5 commits into from
Feb 13, 2025

Conversation

sguequierre
Copy link
Contributor

@sguequierre sguequierre commented Feb 10, 2025 •
edited
Loading

  • add to protos map
  • had to do a bit of work on the automation script

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Feb 10, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 10, 2025 •
edited
Loading

✅ Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 8feaf70
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67ab77bc9bab2d0008ef83b6
😎 Deploy Preview https://deploy-preview-3983--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 21 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sguequierre sguequierre changed the title DOCS-3398: Add flutter methods to automation DOCS-3398: Add data client flutter methods to automation Feb 10, 2025
sguequierre
sguequierre commented Feb 11, 2025
View reviewed changes
.github/workflows/update_sdk_methods.py

if resource in flutter_resource_overrides:
elif sdk == "flutter":
# Initialize Flutter methods dictionary if it doesn't exist
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found this necessary to prevent key_error flutter

@npentrel npentrel merged commit b7ce749 into viamrobotics:main Feb 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npentrel npentrel npentrel approved these changes

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sguequierre @npentrel @viambot