Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-3746: Update robot dog tutorial to use new generator #4116

Merged
merged 2 commits into from
Mar 21, 2025
Merged

DOCS-3746: Update robot dog tutorial to use new generator #4116

merged 2 commits into from
Mar 21, 2025

Conversation

npentrel
Copy link
Collaborator

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Mar 21, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 21, 2025 •
edited
Loading

✅ Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 650cd0a
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67dd8cff84e72100087eb53f
😎 Deploy Preview https://deploy-preview-4116--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 23 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JessamyT JessamyT changed the title DOCS-3746: Update yo usage DOCS-3746: Update robot dog tutorial to use new generator Mar 21, 2025
JessamyT
JessamyT approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if the point of this is to just get the AI to not point to the old generator LGTM but, I’m assuming the generated code doesn’t perfectly match. Did you test it and check whether the code is the same? Also this still uses processes.

docs/tutorials/custom/custom-base-dog.md
- Resource to add to the module (API): `Base Component`.
- Model name: `robotdog`
- Enable cloud build: `No`
- Register module: `Yes`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this since they use it as a local module. Guess it doesn’t matter.

@npentrel
Copy link
Collaborator Author

So, if the point of this is to just get the AI to not point to the old generator LGTM but, I’m assuming the generated code doesn’t perfectly match. Did you test it and check whether the code is the same? Also this still uses processes.

Yeah I think removing Yeoman is priority. I can't really test this easily since I don't have the base. We probably should update processes and then also retest but I think that can be separate. I'll make a ticket.

@npentrel npentrel merged commit 18a10d9 into viamrobotics:main Mar 21, 2025
12 checks passed
@npentrel npentrel deleted the DOCS_3746 branch March 21, 2025 16:21
@github-actions GitHub Actions
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessamyT JessamyT JessamyT approved these changes

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npentrel @JessamyT @viambot