Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-8293] Pass in Connection to Answerer in WebRTC Server #410

Merged
merged 19 commits into from
Feb 5, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint again
bashar-515 committed Feb 4, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 2e66377c2799c12e863b07bb3d72b2d7ad1978dc
1 change: 1 addition & 0 deletions rpc/wrtc_signaling_answerer.go
Original file line number Diff line number Diff line change
@@ -44,6 +44,7 @@ type webrtcSignalingAnswerer struct {
// connection to the signaling server. If this option is not set, the answerer will oversee the lifecycle of its own connection by
// continuosly dialing in the background until a successful connection emerges and closing said connection when done. In the shared
// connection case, the answerer will not close the connection. connMu sync.Mutex
connMu sync.Mutex
conn ClientConn
sharedConn bool


Unchanged files with check annotations Beta

// WithExternalSignalingConn provides a preexisting connection to use. This option forces the webrtcSignalingAnswerer to not dial or manage
// a connection.
func withSignalingConn(signalingConn ClientConn) DialOption {

Check failure on line 289 in rpc/dial_options.go

GitHub Actions / Build and Test

func `withSignalingConn` is unused (unused)
return newFuncDialOption(func(o *dialOptions) {
o.signalingConn = signalingConn
})