Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I've been trying out
eslint-plugin-vitest
in a personal project and it's been helpful. This PR adds this plugin and an opinionated configuration to the base ESLint config that takes includes the recommended config and also takes care of various bits of feedback I've given on PRs.Adding this config to the app triggers about 70 new errors, so this will be a relatively involved upgrade, but the payoff will be more consistent, idiomatic tests.
Review requests:
Review the explicitly enabled tests for any you think are improper:
toBeTruthy
andtoBeFalsey
because they hide bugsvi.spyOn
because partial mocking is harmful