Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint-plugin-vitest #33

Closed
wants to merge 1 commit into from

Conversation

mcous
Copy link
Member

@mcous mcous commented Jan 3, 2024

Overview

I've been trying out eslint-plugin-vitest in a personal project and it's been helpful. This PR adds this plugin and an opinionated configuration to the base ESLint config that takes includes the recommended config and also takes care of various bits of feedback I've given on PRs.

Adding this config to the app triggers about 70 new errors, so this will be a relatively involved upgrade, but the payoff will be more consistent, idiomatic tests.

Review requests:

Review the explicitly enabled tests for any you think are improper:

Copy link
Member

@DTCurrie DTCurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/eslint-config/package.json Outdated Show resolved Hide resolved
tests/peers.spec.ts Outdated Show resolved Hide resolved
tests/peers.spec.ts Outdated Show resolved Hide resolved
@mcous mcous force-pushed the mcous/eslint-vitest branch from 80578aa to c2d4efd Compare January 19, 2024 13:46
@mcous mcous force-pushed the mcous/eslint-vitest branch from c2d4efd to 9cd2c5e Compare January 19, 2024 13:46
@mcous
Copy link
Member Author

mcous commented Jan 19, 2024

Superseded by #35 and #36

@mcous mcous closed this Jan 19, 2024
@mcous mcous deleted the mcous/eslint-vitest branch January 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants