update CI, python version and deps #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmorrow
requested changes
Jan 30, 2025
canary/requirements.txt
Outdated
| pymongo | ||
| numpy | ||
| slack-sdk | ||
| dnspython==2.7.0 |
There was a problem hiding this comment.
I think the better way to do this, rather than explicitly freezing including all transitive deps, is to set just the packages we directly rely on with "compatible" version markers. Given what is in this freeze result, I think that'd look like:
numpy ~= 2.2
pymongo ~= 4.11
python-dateutil ~= 2.2
slack-sdk ~= 3.34
viam-sdk ~= 0.38
| @@ -17,8 +17,8 @@ on: | |||
| env: | |||
| ESP32_CANARY_ROBOT: ${{ secrets.ESP32_CANARY_ROBOT }} | |||
| ESP32_CANARY_ROBOT_PART_ID: ${{ secrets.ESP32_CANARY_ROBOT_PART_ID }} | |||
| ESP32_CANARY_API_KEY_2: ${{ secrets.ESP32_CANARY_API_KEY_2 }} | |||
| ESP32_CANARY_API_KEY_ID_2: ${{ secrets.ESP32_CANARY_API_KEY_ID_2 }} | |||
| ESP32_CANARY_API_KEY: ${{ secrets.ESP32_CANARY_API_KEY }} | |||
There was a problem hiding this comment.
If we no longer need KEY_*_2, please remember to remove them from the repository settings after this merges.
acmorrow
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI python dependencies weren't frozen, additionally we were using python 3.10.
need to test if this works as expected using manual deploy before merging