Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-3601 Add code colors #614

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

katiepeters
Copy link
Member

@katiepeters katiepeters commented Jan 3, 2025

Add colors to our theme for syntax highlighting so that we have something to use in situations where we are not using codemirror but want it to be visually consistent.

@katiepeters katiepeters requested a review from mrloureed January 3, 2025 21:15
@katiepeters katiepeters marked this pull request as ready for review January 3, 2025 21:15
Copy link
Member

@mrloureed mrloureed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

'code-line-number': '#4b758d',
'code-null': '#708',
'code-number': '#2f6447',
'code-property-keys': '#000000',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complete nit: this line could be

      'code-property-keys': '#000',

@katiepeters katiepeters merged commit dbe2e5f into viamrobotics:main Jan 9, 2025
4 checks passed
@katiepeters katiepeters deleted the DATA-3601 branch January 9, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants