New table component (design guide) #622
Open
+665
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
https://viam.atlassian.net/browse/APP-6953
Desire for a table "component", even if only mostly for layout.
Context
<ul />
instead of<table >
due to problems when embedding HTML in table cells (less hidden behavior in HTML elements itself, simpler default CSS with accessibility)theme.ts
is only used for extending Tailwind's default theme settings and not to handle custom CSS class definitions.plugins.ts
is modified to add the table-related classes to ensure these styles are applied globally and available for scalabilityonSorted
hook for sortable tablesNEXT TO DO: Add a design guide to design.viam.com (APP-7487)