Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-6289 pin CI datacenter #3432

Merged
merged 2 commits into from
Jan 12, 2024
Merged

RSDK-6289 pin CI datacenter #3432

merged 2 commits into from
Jan 12, 2024

Conversation

abe-winter
Copy link
Member

What changed

  • pin 3 arm64 jobs to a specific datacenter
  • remove coverage test run (keep the data race run)

Why

  • in theory reduce CI timeouts in the image pull step
  • coverage decision in slack, but basically to speed up tests + halve our flake risk

Sample run

https://github.com/viamrobotics/rdk/actions/runs/7495123827

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jan 11, 2024
@abe-winter abe-winter changed the title pin CI datacenter RSDK-6289 pin CI datacenter Jan 11, 2024
Otterverse
Otterverse approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think this will help, go for it. It sounded like they fixed something on their end from what was said in slack though. Totally your call either way!

@abe-winter
Copy link
Member Author

their rep said to still try pinning

@abe-winter abe-winter merged commit 1e1910b into main Jan 12, 2024
33 of 45 checks passed
@abe-winter abe-winter deleted the ci-pin branch January 12, 2024 00:10
tahiyasalam pushed a commit to tahiyasalam/rdk that referenced this pull request Jan 16, 2024
@abe-winter @tahiyasalam
RSDK-6289 pin CI datacenter (viamrobotics#3432)
f4a89c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Otterverse Otterverse Otterverse approved these changes

@dgottlieb dgottlieb Awaiting requested review from dgottlieb

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abe-winter @Otterverse @viambot