Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2082: Add camera encoder gantry snippets #3824

Conversation

skyleilani
Copy link
Contributor

@skyleilani skyleilani commented Apr 18, 2024

Labeled as a draft while I review and test code snippets

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Apr 18, 2024
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
motion GetPose
vision ClassificationsFromCamera

Copy link
Contributor

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests are passing

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 19, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 19, 2024
@npentrel
Copy link
Contributor

@skyleilani I think you need to sign the contributor license agreement (see top comment).
@njooma who should review these PRs?

@njooma
Copy link
Member

njooma commented Apr 22, 2024

@npentrel anyone on SDK could review these.

@skyleilani can you post a screenshot of what these comments look like when rendered?

@skyleilani
Copy link
Contributor Author

@njooma

here is a side by side of a comment and what it looks like being rendered within the interface's code snippet:

Screenshot 2024-04-17 at 3 22 08 PM

@npentrel
Copy link
Contributor

@njooma happy with the screenshots? Let us know so we can merge

@skyleilani skyleilani marked this pull request as draft April 25, 2024 21:01
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 26, 2024
@skyleilani skyleilani marked this pull request as ready for review April 26, 2024 17:53
@skyleilani skyleilani merged commit 6ab84fb into viamrobotics:main Apr 26, 2024
16 checks passed
@skyleilani skyleilani deleted the DOCS-2082-Add-camera-encoder-gantry-snippets branch April 26, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants