Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-7328: Change DigitalIntrruptByName to return a DigitalInterrupt and an error #3826

Closed
wants to merge 0 commits into from
Closed

RSDK-7328: Change DigitalIntrruptByName to return a DigitalInterrupt and an error #3826

wants to merge 0 commits into from

Conversation

martha-johnston
Copy link
Contributor

No description provided.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
motion GetPose
vision ClassificationsFromCamera

@martha-johnston martha-johnston requested review from a team and randhid and removed request for a team April 19, 2024 15:14
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 19, 2024
randhid
randhid approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@randhid randhid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor error nits, please address them and feel free to merge!

components/board/genericlinux/board.go Outdated Show resolved Hide resolved
components/board/hat/pca9685/pca9685.go Outdated Show resolved Hide resolved
components/board/numato/board.go Outdated Show resolved Hide resolved
components/board/pi/impl/board.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 19, 2024
@martha-johnston
Copy link
Contributor Author

@randhid do you have any idea why this pi test might be failing? I can't reproduce locally

@martha-johnston
Copy link
Contributor Author

martha-johnston commented Apr 24, 2024 •
edited
Loading

just as an update, this test is passing on my pi so not sure why it's failing here. will keep debugging

edit: no it's not I was in the wrong rdk folder oops

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 24, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randhid randhid randhid approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martha-johnston @randhid @viambot