Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-7328: Change DigitalIntrruptByName to return a DigitalInterrupt and an error #3853

Merged
merged 18 commits into from
Apr 26, 2024
Merged

RSDK-7328: Change DigitalIntrruptByName to return a DigitalInterrupt and an error #3853

merged 18 commits into from
Apr 26, 2024

Conversation

martha-johnston
Copy link
Contributor

accidentally closed my other pr

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Apr 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
motion GetPose
vision ClassificationsFromCamera

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 25, 2024
@martha-johnston martha-johnston requested a review from randhid April 25, 2024 12:07
@martha-johnston
Copy link
Contributor Author

tried to merge main in a weird way and accidentally closed my old PR. This is the same just updated with main

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 25, 2024
randhid
randhid approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@randhid randhid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Edit please run packages changed with go test -race

components/board/fake/board.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 25, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 25, 2024
@martha-johnston
Copy link
Contributor Author

okay now actually running everything on the right branch and these tests are still passing locally on a pi. any suggestions on how to repo?

@randhid
Copy link
Member

randhid commented Apr 25, 2024

okay now actually running everything on the right branch and these tests are still passing locally on a pi. any suggestions on how to repo?

What are you running on the pi? make test or make test-pi?

@martha-johnston
Copy link
Contributor Author

What are you running on the pi? make test or make test-pi?

go test -run TestPiPigpio

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 25, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 25, 2024
@martha-johnston
Copy link
Contributor Author

still never got it to fail on my pi but I did figure out why it was failing so

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 25, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 26, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 26, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Apr 26, 2024
@martha-johnston martha-johnston merged commit 1aa9cb5 into viamrobotics:main Apr 26, 2024
16 checks passed
dgottlieb pushed a commit that referenced this pull request Apr 29, 2024
@martha-johnston @randhid
RSDK-7328: Change DigitalIntrruptByName to return a DigitalInterrupt …
f86717d 
…and an error (#3853)

Co-authored-by: randhid <[email protected]>
10zingpd pushed a commit that referenced this pull request Apr 29, 2024
@martha-johnston @randhid @10zingpd
RSDK-7328: Change DigitalIntrruptByName to return a DigitalInterrupt …
212b14a 
…and an error (#3853)

Co-authored-by: randhid <[email protected]>
@martha-johnston martha-johnston deleted the rsdk-7328 branch May 20, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randhid randhid randhid approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martha-johnston @randhid @viambot