Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-2231-Add-Gripper-Input-Controller-snippets #3919

Merged
merged 8 commits into from
May 9, 2024
Merged

DOCS-2231-Add-Gripper-Input-Controller-snippets #3919

merged 8 commits into from
May 9, 2024

Conversation

skyleilani
Copy link
Contributor

Samples reviewed: viamrobotics/docs#2860

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label May 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
motion GetPose
vision ClassificationsFromCamera

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 7, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 8, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 8, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 8, 2024
@skyleilani skyleilani requested a review from cheukt May 8, 2024 17:20
cheukt
cheukt reviewed May 8, 2024
View reviewed changes
components/input/input.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 8, 2024
@skyleilani skyleilani requested a review from cheukt May 8, 2024 20:34
cheukt
cheukt reviewed May 8, 2024
View reviewed changes
components/input/input.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 9, 2024
@skyleilani skyleilani requested a review from cheukt May 9, 2024 20:22
cheukt
cheukt approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but make sure to update the variable name!

components/input/input.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 9, 2024
@skyleilani skyleilani merged commit dc7e0bf into viamrobotics:main May 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessamyT JessamyT JessamyT left review comments

@npentrel npentrel npentrel approved these changes

@cheukt cheukt cheukt approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skyleilani @npentrel @JessamyT @cheukt @viambot