override nodejs to unbreak antique builds #4589
Merged
+19
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
/__e/node20/node
to the container's node 16 intallationno-upload
bool to workflow_dispatch for the static build workflow (to support my testing today)Why
The actions nodejs install (
/__e/node20/node
) now requires GLIBC 2_28 and we have 2_27; antique builds are failing as a result, example here. Context: the antique container intentionally links against old GLIBC for broad compatibility.Successful run
https://github.com/viamrobotics/rdk/actions/runs/12039219859