[RSDK-9520] Refactor NextPointCloud -> PointCloud and add extra param
#4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date related tests This commit updates the camera interface by renaming the method `NextPointCloud` to `PointCloud`, reflecting a more consistent naming convention. All instances of the method across various files, including tests and implementations, have been modified accordingly. The new method signature includes the `extra` parameter to match the proto API, enhancing flexibility and aligning the interfaces. Changes include: - Updated method definitions and calls in `camera.go`, `client.go`, `videosourcewrappers.go`, and other related files. - Adjusted test cases to use the new method name and signature. This refactor improves code clarity and prepares the codebase for further updates to point cloud processing.
viambot
added
the
safe to test
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
randhid
reviewed
Dec 13, 2024
| // a part of a sequence. In the future, there could be streaming of point clouds. | ||
| NextPointCloud(ctx context.Context) (pointcloud.PointCloud, error) | ||
| PointCloud(ctx context.Context, extra map[string]interface{}) (pointcloud.PointCloud, error) |
There was a problem hiding this comment.
Bro... I just realized this thing has a mimetype and returns bytes too....
https://github.com/viamrobotics/api/blob/a97363bad4477f2a2320c28be0d12447d9a81f89/proto/viam/component/camera/v1/camera.proto#L107
There was a problem hiding this comment.
We are ok to handle mimetype inclusion in another PR? There are no consequences wrt data capture by adding in extra to the interface method here?
There was a problem hiding this comment.
We are ok to handle mimetype inclusion in another PR?
If we are going to break the same interface I'd rather not do it twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor camera interface: rename NextPointCloud to PointCloud and update related tests
This PR updates the camera interface by renaming the method
NextPointCloudtoPointCloud, reflecting a more consistent naming convention. All instances of the method across various files, including tests and implementations, have been modified accordingly. The new method signature includes theextraparameter to match the proto API, enhancing flexibility and aligning the interfaces.Changes include:
camera.go,client.go,videosourcewrappers.go, and other related files.This refactor improves code clarity and prepares the codebase for further updates to point cloud processing.