update go sdk sort of #4733
Draft
update go sdk sort of #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
dgottlieb
reviewed
Jan 30, 2025
| @@ -438,7 +438,7 @@ func (d *DataClient) TabularDataBySQL(ctx context.Context, organizationID, sqlQu | |||
|
|
|||
| // TabularDataByMQL queries tabular data with MQL (MongoDB Query Language) queries. | |||
| func (d *DataClient) TabularDataByMQL( | |||
| ctx context.Context, organizationID string, query []map[string]interface{}, | |||
| ctx context.Context, organizationID string, query []map[string]interface{}, useRecentData bool, | |||
There was a problem hiding this comment.
I know this is only a draft, but just surfacing that I expect this to be a breaking change. But I don't have any context on whether this was already agreed upon or if other options are being weighed.
There was a problem hiding this comment.
Oh I didn't talk to sdk at all about this yet, good point tho. I think there might be a way to make this optional but we're not near that point yet. I made this draft just to test things on the read side with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.