RSDK-9839: Have Go module clients be webrtc aware. #4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h module names. Pass a VIAM_MODULE_NAME env variable to module processes.
viambot
added
the
safe to test
benjirewis
reviewed
Jan 31, 2025
There was a problem hiding this comment.
So I think some other changes to grpc/shared_conn.go and a couple other files slipped into here from the last version I saw?
I'll probably need a brief synchronous meeting to understand what's happening with the NewSharedConnForModule function and some of the peer connection grabbing and setting. Or you can definitely bypass my review and get @nicksanford's or someone with more context. Up to you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.