RSDK-11429: robot shutdown while module restarting should not error #5359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the error in mod.client.RemoveResource() is a ErrNotConnected (which is returned by invoke() in conn.go), it means that the modules are disconnected. These changes will ignore that error, which makes sense because if the module is disconnected from restarting/failing, the resources are already removed and it hasn't failed. This function calls the mod.client.RemoveResource() defined in the viam.api repo
Test results
TestCrashedModelReregisteredAfterRecovery with addition of t.FailNow():
after these changes