RSDK-12147 Audio Out component #5373
Conversation
viambot
added
the
safe to test
|
@oliviamiller This PR also includes audioin diff, should we just review audioout related changes here? |
Yeah I branched off audioin since there is some shared code, you can just review audioout here or hold off on reviewing until the audioin PR is merged. |
got it i'll wait until the audioin changes are finalized and the diff is less confusing |
| // SubtypeName is a constant that identifies the audio out resource subtype string. | ||
| const SubtypeName = "audio_out" | ||
|
|
||
| // API is a variable that identifies the audio input resource API. |
There was a problem hiding this comment.
This should say the audio output, right?
There was a problem hiding this comment.
yep, thanks for catching
| @@ -0,0 +1,188 @@ | |||
| package audioout_test | |||
| // Properties defines properties of an audio device. | ||
| type Properties struct { | ||
| SupportedCodecs []string | ||
| SampleRate int32 |
There was a problem hiding this comment.
Can this be renamed to SampleRateHz?
| // AudioInfo defines information about audio data. | ||
| type AudioInfo struct { | ||
| Codec string | ||
| SampleRate int32 |
| func AudioInfoPBToStruct(pb *commonpb.AudioInfo) *AudioInfo { | ||
| return &AudioInfo{ | ||
| Codec: pb.Codec, | ||
| SampleRate: pb.SampleRate, |
| func AudioInfoStructToPb(info *AudioInfo) *commonpb.AudioInfo { | ||
| return &commonpb.AudioInfo{ | ||
| Codec: info.Codec, | ||
| SampleRate: info.SampleRate, |
| golang.org/x/exp v0.0.0-20241009180824-f66d83c29e7c | ||
| ) | ||
|
|
||
| replace go.viam.com/api => ../api |
There was a problem hiding this comment.
This is temporary while the proto API is not submitted, right?
5 participants
please review #5369 first.
Scope: https://docs.google.com/document/d/1dEurb36y4Aysdj17imofuZwEZlGpC_I4l5D6bmN4Igw/edit?tab=t.0