Cleanup event handlers on disconnect #662
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event listeners for WebRTC connection state changes were not cleared during reconnections, causing handlers to accumulate with every reconnect. This resulted in old handlers firing on stale connections and potential race conditions due to duplicate event handling.
This PR implements event listener lifecycle management in RobotClient by adding class properties to store handler references (
onICEConnectionStateChange,onDataChannelClose,onTrack), creating thecleanupEventListenersmethod to clear handler references, updatingconnectto call cleanup before registering new handlers, and updatingdisconnectto clean up handlers before closing connections.It also introduces test coverage for
client.ts, though the tests are currently limited just to event handling.