Fix session reset on reconnection with saved creds #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTCurrie
requested review from
lia-viam and
njooma
and removed request for
a team
DTCurrie
changed the title
njooma
approved these changes
Nov 4, 2025
Good question, I did not dive any deeper than the TS SDK. It was a todo from a long-closed ticket so may be worth taking a look at how other SDKs are handling this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sessions were unconditionally reset on every reconnection, even when reusing the same credentials. This caused authentication context mismatches and unnecessary session churn.
This PR modifies
client.tsto conditionally reset sessions only when:This PR also introduces unit-tests to cover expected behaviors for the client's session management.