meta/codegen.d: Fix getSymbols for dlang/dmd#11320 #2458
Conversation
|
A comment would be nice |
|
@Geod24 I've edited the description and added links, hope that's ok |
utils/vibe/internal/meta/codegen.d
Outdated
| @@ -78,7 +78,7 @@ template getSymbols(T) | |||
| alias Implementation = TypeTuple!(); | |||
| } | |||
|
|
|||
| alias getSymbols = NoDuplicates!(Implementation!T); | |||
| alias getSymbols = NoDuplicates!(staticMap!(Unqual, Implementation!T)); | |||
There was a problem hiding this comment.
This has compile-time performance implications.
There was a problem hiding this comment.
Isn't this a breaking change? Wouldn't the original say AliasSeq!(int, const(int)) for int[const(int)]? alias parameters seem to allow const(int) to go through, whereas Unqual!(const(int)) turns into int
There was a problem hiding this comment.
Actually I think basic types are ignored anyway
There was a problem hiding this comment.
Yep, you are right, I didn't realize that.
There was a problem hiding this comment.
Instead of this can you apply Unqual at the leaf instantiations? That would prevent the need for static map.
ntrel
changed the title
|
looking at the usage (figure out which imports need to happen to include these symbols), I think this change is correct in terms of what this thing is meant to do. I would suggest a document comment that clarifies that attributes will be stripped from types. |
This fixes #2455. Instead of changing the assert I just made getSymbols continue dropping qualifiers, because that will work with both existing and future dmd.
See dlang/dmd#11320.