db/redis: add tests for FieldMap() #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.15% (diff: 100%)@@ master #141 diff @@
==========================================
Files 28 28
Lines 1907 1907
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1624 1624
Misses 188 188
Partials 95 95
|
fsouza
reviewed
Nov 14, 2016
| @@ -11,6 +11,8 @@ import ( | |||
| "sync" | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "github.com/NYTimes/video-transcoding-api/db" | |||
There was a problem hiding this comment.
A quick note that this package doesn't depend on anything else in the video-transcoding-api on purpose: it's an independent library and if we want to extract this as an external repo, we could, and then users wouldn't need to download the video-transcoding-api code.
You tests don't change this because you're importing code from video-transcoding-api only in the test file, but the ideal approach would be to add a []struct{} field to some of the types declared in stub_test.go and use those types in the tests for FieldMap.
|
@fsouza should be done now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I started this branch to solve the issue #139 so I wrote tests to instrument the modifications. The code to support flatten arrays of structs into hashes sounds like a workaround and I decided to give up.
Talking with @fsouza we'll probably abort this approach and save the json as a string.