Skip to content

Conversation

@maxfenton
Copy link
Contributor

  • adds a config/general.php alias for @primarySiteUrl that always has a trailing slash
  • updates the default Site to use the alias
  • updates config/vite.php to remove that trailing slash

@maxfenton maxfenton requested a review from joshuapease October 1, 2025 15:40
@maxfenton maxfenton self-assigned this Oct 1, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to put this file in a separate PR?

We'll also need to update composer-scripts/post-create-project.php to change that PRIMARY_SITE_URL

I'm happy to make that change, or feel free to go for it if you have time.

If you hit any snags testing it out, I'm happy to pair up later this week or early tomorrow.

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the extra changes and force-pushed. I don't really understand about the post-create-project.php file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little funky. We should just finally do our Craft modules 1:1 and maybe piggy back some site starter stuff while we're doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants