Skip to content

[#182] Refactor after TW 4 update #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025
Merged

Conversation

nathan-schmidt-viget
Copy link
Contributor

Summary

  • Breaks the tailwind.css file into smaller parts.
  • Moves the ! to the end per the TW 4 docs
  • Adds button vars so it is easier to just update the colors
  • Updates fluid spacing to pull from the default spacing
  • Updates the JS to extract the colors from the color.css file

Issues

Testing Instructions

  1. Make sure the theme.json has the newest css when you build the files.
  2. Updating the colors in button.css to make sure is updates the button's hover/focus states.

Screenshots

NA

@nathan-schmidt-viget nathan-schmidt-viget marked this pull request as ready for review July 15, 2025 12:58
Copy link
Contributor

@bd-viget bd-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm kind of a huge fan of changing the ! to now be at the end of the class name (as it should be), this is going to take me a while to get used to 😆.

Also using the variables in the class names is going to take some getting used to for me.

Just made one adjustment to the outline variable name since the bg should be transparent and the border is the color we want to customize.

@nathan-schmidt-viget nathan-schmidt-viget merged commit d78a9b8 into main Jul 17, 2025
1 check passed
@nathan-schmidt-viget nathan-schmidt-viget deleted the ns/182-refactor-tw branch July 17, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants