Skip to content

fix: force utf-8 for all open calls except PDF #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vilcans merged 1 commit into from
Jan 5, 2026
Merged

fix: force utf-8 for all open calls except PDF #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions screenplain/export/html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,6 @@ def _tag(self, tag_name, classes=[]):
return tag(self.out, tag_name, classes)


def _read_file(filename):
with open(path) as stream:
return stream.read()


def convert(screenplay, out, css_file=None, bare=False):
"""Convert the screenplay into HTML, written to the file-like object `out`.

Expand All @@ -191,7 +186,7 @@ def convert_full(screenplay, out, css_file):
written to the file-like object `out`.

"""
with open(css_file, 'r') as stream:
with open(css_file, 'r', encoding='utf-8') as stream:
css = stream.read()
out.write(
'<!DOCTYPE html>\n'
Expand Down
2 changes: 1 addition & 1 deletion tests/files_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@


def read_file(path):
with open(path) as stream:
with open(path, encoding="utf-8") as stream:
return stream.read()


Expand Down