#548

README.md

@@ -276,6 +276,11 @@ first request.
 
 When a `userResHeaderDecorator` is defined, the return of this method will replace (rather than be merged on to) the headers for `userRes`.
 
+> Note that by default, headers from the PROXY response CLOBBER all headers that may have previously been set on the userResponse. 
+> Authors have the option of constructing any combination of proxyRes and userRes headers in the `userResHeaderDecorator`. 
+> Check the tests for this method for examples.
+
+
 ```js
 app.use('/proxy', proxy('www.google.com', {
   userResHeaderDecorator(headers, userReq, userRes, proxyReq, proxyRes) {

test/decorateUserResHeaders.js

@@ -32,7 +32,6 @@ describe('when userResHeaderDecorator is defined', function () {
   });
 
   it('can delete a header', function (done) {
-
     app.use('/proxy', proxy('http://127.0.0.1:12345', {
       userResHeaderDecorator: function (headers /*, userReq, userRes, proxyReq, proxyRes */) {
         delete headers['x-my-secret-header'];
@@ -54,7 +53,6 @@ describe('when userResHeaderDecorator is defined', function () {
   });
 
   it('provides an interface for updating headers', function (done) {
-
     app.use('/proxy', proxy('http://127.0.0.1:12345', {
       userResHeaderDecorator: function (headers /*, userReq, userRes, proxyReq, proxyRes */) {
         headers.boltedonheader = 'franky';
@@ -74,4 +72,39 @@ describe('when userResHeaderDecorator is defined', function () {
       .end(done);
   });
 
+  it('author has option to copy proxyResponse headers to userResponse', function (done) {
+    app.use('/proxy', proxy('http://127.0.0.1:12345', {
+      userResHeaderDecorator: function (headers, userReq) { // proxyReq
+        // Copy specific headers from the proxy request to the user response
+        //
+        // We can copy them to new name
+        if (userReq.headers['x-custom-header']) {
+          headers['x-proxied-custom-header'] = userReq.headers['x-custom-header'];
+        }
+        if (userReq.headers['x-user-agent']) {
+          headers['x-proxied-user-agent'] = userReq.headers['x-user-agent'];
+        }
+
+        // We can copy them to the same name
+        headers['x-copied-header-1'] = userReq.headers['x-copied-header-1'];
+        headers['x-copied-header-2'] = userReq.headers['x-copied-header-2'];
+        return headers;
+      }
+    }));
+
+    request(app)
+      .get('/proxy')
+      .set('x-custom-header', 'custom-value')
+      .set('x-user-agent', 'test-agent')
+      .set('x-copied-header-1', 'value1')
+      .set('x-copied-header-2', 'value2')
+      .expect(function (res) {
+        // Verify the original headers were proxied to the response
+        assert.equal(res.headers['x-proxied-custom-header'], 'custom-value');
+        assert.equal(res.headers['x-proxied-user-agent'], 'test-agent');
+        assert.equal(res.headers['x-copied-header-1'], 'value1');
+        assert.equal(res.headers['x-copied-header-2'], 'value2');
+      })
+      .end(done);
+  });
 });