Skip to content

Add options to assume Injectivity On Inhale and to disable it#442

Merged
jcp19 merged 3 commits intomasterfrom
add-toggle-injectivity-checks
May 3, 2022
Merged

Add options to assume Injectivity On Inhale and to disable it#442
jcp19 merged 3 commits intomasterfrom
add-toggle-injectivity-checks

Conversation

@jcp19
Copy link
Contributor

@jcp19 jcp19 commented May 2, 2022

This PR would optimally be combined with PR #409, but we can merge it already. When #409 is merged, we should adapt the default value of the option and its description. (This option should exist though even after we merge #409, as it might be necessary to verify already existing codebases like SCION)

PS: We can merge this after merging #434 to avoid more changes in that PR

@jcp19 jcp19 requested a review from ArquintL May 2, 2022 09:30
Copy link
Member

@ArquintL ArquintL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only two small comments

Co-authored-by: Linard Arquint <ArquintL@users.noreply.github.com>
@jcp19 jcp19 merged commit d5ffbb0 into master May 3, 2022
@jcp19 jcp19 deleted the add-toggle-injectivity-checks branch May 3, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants