Match on PIdnUseExp instead of PIdnUse#908
Merged
rayman2000 merged 4 commits intoviperproject:masterfrom Mar 17, 2025
LaurenzV:test-fix
Merged
Match on PIdnUseExp instead of PIdnUse#908rayman2000 merged 4 commits intoviperproject:masterfrom LaurenzV:test-fix
PIdnUseExp instead of PIdnUse#908rayman2000 merged 4 commits intoviperproject:masterfrom
LaurenzV:test-fix
Conversation
Contributor
Author
|
I'm not sure what's going on, but now it fails even earlier when checking out the branch: https://github.com/viperproject/silver/actions/runs/13896191787/job/38877256432?pr=820 😅 I'm not sure why, but I presume my merge commit from main somehow trips it up when trying to check out silver now... I presume the PR should have been squashed before merging, any idea how to fix? |
Contributor
|
Hmm not sure if we can easily remove commits, we have branch protection on. Reverting the changes in a new commit will not solve this problem right? |
Contributor
Author
|
I think not, but I'm also not sure what exactly the problem is, because the submodule still seems to link to viperproject/silver... Is it somehow possible to manually trigger a update submodules from Silver Bot? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary for viperproject/silver#820.