Restricting recursiveCallsAndSurroundingUnfoldings to look for recursive calls only#896
Merged
marcoeilers merged 1 commit intomasterfrom Nov 5, 2025
Merged
Restricting recursiveCallsAndSurroundingUnfoldings to look for recursive calls only#896marcoeilers merged 1 commit intomasterfrom
marcoeilers merged 1 commit intomasterfrom
Conversation
Contributor
|
I'm a bit worried about solving it this way wrt to mutually recursive calls however |
Contributor
Author
|
We could of course look at the actual function call graph to also support mutual recursion. I didn't want to do that because I've seen call graph computation being slow, and I'm not sure I've ever seen a case where this would matter. But actually call graph computation was slow because we're hashing functions for no reason (see #867), so I'll just fix that, and then we can use the call graph here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JonasAlaif found that predicate triggers don't apply just to recursive calls but to any function calls, which is almost certainly not intended, contradicts the name of the function that looks for relevant calls, and can easily lead to matching loops (see #895).
While there are other issues with the way the triggers are generated, this PR just fixes the most glaring issue and restricts the triggers to look for actual recursive calls only.