Adapt to change that replaces method command line option with better select option#317
Merged
marcoeilers merged 1 commit intomasterfrom Oct 17, 2025
Merged
Conversation
…better select option
rayman2000
approved these changes
Oct 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Is there a way to get some kind of "keep trying to merge until it works" functionality? :D |
Contributor
|
I think you are not supposed to have a CI/CD pipeline that just fails sometimes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapting the change made in viperproject/silver#886, which will also fix compile error currently preventing us from updating submodules.
That PR replaced the old
--methodcommand line option that only filtered out methods without looking at dependencies at all (and that I've never seen anyone use anyway) with a new--selectcommand line option that uses the Chopper to filter the selected members and their dependencies.This PR makes the same change here.