Fixing syntax error

src/loess.jl

@@ -1,68 +1,60 @@
 # TODO Check faster implementations in computational methods for local regression
 # William S. Cleveland & E. Grosse https://link.springer.com/article/10.1007/BF01890836
-function ghat(x::T;
-           A::AbstractMatrix{T},
-           b::AbstractVector{T},
-           d::Integer=2,
-           q::Integer,
-           rho::AbstractVector{T}) where T<:Real
-
-    xv = A[:,d]
-    yv = b
+function ghat(x::T,
+    A::AbstractMatrix{T},
+    b::AbstractVector{T},
+    d::Integer,
+    q::Integer,
+    rho::AbstractVector{T}) where T<:Real
+
+xv = A[:,d]
+yv = b
+
+## λ_q
+n = length(xv)
+q = min(q,n)
+xvx = @. abs(xv-x)
+qidx = sortperm(xvx)[1:q]
+qdist = abs(xv[last(qidx)]-x)*max(1.0,q/n)
+
+## upsilon
+w = zeros(n)
+for wi in qidx
+ aq = abs(xv[wi]-x)/qdist
+ w[wi] = max((1-aq^3)^3,0.0)
+end
 
-    ## λ_q
-    n = length(xv)
-    q = min(q,n)
-    xvx = @. abs(xv-x)
-    qidx = sortperm(xvx)[1:q]
-    qdist = abs(xv[last(qidx)]-x)*max(1.0,q/n)
+A = @. A*(w*rho)
+b = @. b*(w*rho)
 
-    ## upsilon
-    w = zeros(n)
-    for wi in qidx
-        aq = abs(xv[wi]-x)/qdist
-        w[wi] = max((1-aq^3)^3,0.0)
-    end
-
-    A = @. A*(w*rho)
-    b = @. b*(w*rho)
-
-    lsq_x = A\b
+lsq_x = A\b
 
-    d == 1 ? [x,1.0]'*lsq_x : [x^2.0,x,1.0]'*lsq_x
+d == 1 ? [x,1.0]'*lsq_x : [x^2.0,x,1.0]'*lsq_x
 
 end
 
 """
 Package: Forecast
-
-    loess(xv, yv;
-          d = 2,
-          q = Int64(round(3/4*length(xv))),
-          rho = repeat([1.0],inner=length(xv)),  
-          predict = xv)
-
+loess(xv, yv;
+   d = 2,
+   q = Int64(round(3/4*length(xv))),
+   rho = repeat([1.0],inner=length(xv)),  
+   predict = xv)
 Smooth a vector of observations using locally weighted regressions.
-
 Although loess can be used to smooth observations for any given number of independent variables, this implementation is univariate. The speed of loess can be greatly increased by using fast aproximations for the linear fitting calculations, however this implementation calculates only exact results.
-
 The loess functionality and nomenclature follows the descriptions in:
-
 "STL: A Seasonal, Trend Decomposition Procedure Based on Loess"
 Robert B. Cleveland, William S. Cleveland, Jean E. McRae, and Irma Terpenning.
 Journal of Official Statistics Vol. 6. No. 1, 1990, pp. 3-73 (c) Statistics Sweden.
-
 # Arguments
 - `xv`: Observations' support.
 - `yv`: Observation values.
 - `d`: Degree of the linear fit, it accepts values 1 or 2.
 - `q`: As q increases loess becomes smoother, when q tends to infinity loess tends to an ordinary least square poynomial fit of degree `d`. It defaults to the rounding of 3/4 of xv's length.
-    - `rho`: Weights expressing the reliability of the observations (e.g. if yi had variances σ^2*ki where ki where known, the rhoi could be 1/ki). It defaults to 1.0.
+- `rho`: Weights expressing the reliability of the observations (e.g. if yi had variances σ^2*ki where ki where known, the rhoi could be 1/ki). It defaults to 1.0.
 - `predict`: Vector containing the real values to be predicted, by default predicts xv.
-
 # Returns
 The loess values for the values contained in `predict`.
-
 # Examples
 ```julia-repl
 julia> loess(rand(5), rand(5); predict=rand(10))
@@ -71,37 +63,37 @@ julia> loess(rand(5), rand(5); predict=rand(10))
 ```
 """
 function loess(xv::AbstractVector{R},
-               yv::AbstractVector{<:Union{Missing,S}}; 
-               d::Integer=2,
-               q::Integer=Int64(round(3/4*length(xv))),
-               rho::AbstractVector{<:Union{Missing,T}}=fill(1.0,length(xv)),  
-               predict::AbstractVector{V} = xv) where {R<:Real, S<:Real, T<:Real, V<:Real}
-
-    @assert (d==1) | (d==2) "Linear Regression must be of degree 1 or 2"
-    @assert length(xv) == length(yv)
-
-    myi = findall(x -> !ismissing(x),yv)
-    xv = xv[myi]
-    yv = yv[myi]
-    rho = rho[myi]
-
-    # Promote to same type
-    P = promote_type(R,S,T,V)
-    xv = R == P ? xv :  P.(xv)
-    yv =  P.(yv)
-    rho = P.(rho)
-    predict = V == P ? predict : P.(predict)
-    
-    res = Vector{P}(undef, length(predict))
-
-    ## Ax = b
-    A = hcat(xv,fill(P(1),length(xv)))
-    b = yv
-    d == 2 && (A = hcat(xv .^ 2, A))
-
-    for (i,xi) in enumerate(predict)
-        res[i] = ghat(xi;A,b,d,q,rho)
-    end
+        yv::AbstractVector{<:Union{Missing,S}}; 
+        d::Integer=2,
+        q::Integer=Int64(round(3/4*length(xv))),
+        rho::AbstractVector{<:Union{Missing,T}}=fill(1.0,length(xv)),  
+        predict::AbstractVector{V} = xv) where {R<:Real, S<:Real, T<:Real, V<:Real}
+
+@assert (d==1) | (d==2) "Linear Regression must be of degree 1 or 2"
+@assert length(xv) == length(yv)
+
+myi = findall(x -> !ismissing(x),yv)
+xv = xv[myi]
+yv = yv[myi]
+rho = rho[myi]
+
+# Promote to same type
+P = promote_type(R,S,T,V)
+xv = R == P ? xv :  P.(xv)
+yv =  P.(yv)
+rho = P.(rho)
+predict = V == P ? predict : P.(predict)
+
+res = Vector{P}(undef, length(predict))
+
+## Ax = b
+A = hcat(xv,fill(P(1),length(xv)))
+b = yv
+d == 2 && (A = hcat(xv .^ 2, A))
+
+for (i,xi) in enumerate(predict)
+ res[i] = ghat(xi,A,b,d,q,rho)
+end
 
-    res
+return res
 end