Add From implementation to Certificate when cert_nossl #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BRA1L0R
requested review from
DGonzalezVillal,
larrydewey and
tylerfanelli
as code owners
DGonzalezVillal
requested changes
Dec 19, 2025
Member
There was a problem hiding this comment.
Hey I do appreciate the version bump, but we prefer having bumps when we are ready to cut release in a separate PR. It makes it easier for us to keep track everything that has been added into the repo between releases.
Member
|
The code itself looks good although. Please make sure you add your sign to the commits and also please raise an issue regarding the &Certificate From implementation. |
Author
|
Got it, i'll create a new pr with signed commits and no version bump and
the other implementation you mentioned. Thanks.
…On Fri, Dec 19, 2025, 6:44 PM DGonzalezVillal ***@***.***> wrote:
*DGonzalezVillal* left a comment (virtee/sev#356)
<#356 (comment)>
The code itself looks good although. Please make sure you add your sign to
the commits and also please raise an issue regarding the &Certificate From
implementation.
—
Reply to this email directly, view it on GitHub
<#356 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZBE35B3B3OE7P5IY5VRL4CQ2OBAVCNFSM6AAAAACMBOPTC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNZVHE3DKMJQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Certificateimplementation under cert_nossl.rs (the one used when the cert_nossl feature is enabled) is missing a From implementation between theCertificatewrapper and the innerx509_cert::CertificateI also bumped the minor version as this does not break current APIs.
On a side note, the currently implemented From<&Certificate> (and the other way around) in the openssl implementation are wrong. Cloning should not be done implicitly inside From implementation.
I addede a cert method returning a reference to the inner type to support cloning explicitly the x509_cert certificate type instead of cloning it implicitly via
.into()