Lax parser feature #363
Open
Lax parser feature #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschramm
requested review from
DGonzalezVillal,
larrydewey and
tylerfanelli
as code owners
cschramm
force-pushed
the
lax-decoders
branch
from
e6e308a to
629cd46
Compare
The parser strictly checks reserved areas to be zero (even though the specification does not even require that for all of them). This is an issue when parsing newer versions of attestation reports where those areas might not be reserved anymore. The `lax-parser` feature disables that check, currently with some tradeoffs: * No `WriteExt::skip_bytes` * No `Encoder` impl for `AttestationReport`, `Signature`, and `WrappedVlekHashstick` * No compatibility with `openssl` and `crypto_nossl` Closes virtee#343 Signed-off-by: Christopher Schramm <[email protected]>
cschramm
force-pushed
the
lax-decoders
branch
from
629cd46 to
e5c58d6
Compare
Member
|
So in this solution, you would only be able to parse the attestation report, but you would not be able to write it anywhere correct? Is that still useful to you? |
Member
|
Because the Write stuff can be modified to write the raw contents. Create something like a raw write |
Author
Absolutely, yes. I only use the parser, but not the As I wrote in #343, writing could be achieved by actually reading reserved areas and carrying their contents to write them back instead of zeroes. I was under the impression, though, that you wanted to keep this a limited parse-only case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser strictly checks reserved areas to be zero (even though the specification does not even require that for all of them). This is an issue when parsing future (i.e., not known to the current codebase) versions of attestation reports, where those areas may no longer be reserved.
The
lax-parserfeature disables that check, currently with some tradeoffs:WriteExt::skip_bytesEncoderimplforAttestationReport,Signature, andWrappedVlekHashstickopensslandcrypto_nosslCloses #343