chore: include page_swap_disabled bitfield in AttestationReport comments #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated comment on AttestationReport in firmware/guest/types/snp.rs to include the missing format-change entry: page_swap_disabled in GuestPolicy Signed-off-by: Takuma IMAMURA <[email protected]>
hyperfinitism
requested review from
DGonzalezVillal,
larrydewey and
tylerfanelli
as code owners
DGonzalezVillal
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request just updates the comment above
AttestationReportinfirmware/guest/types/snp.rsto include the missing format‐change entry: thepage_swap_disabledbitfield in theGuestPolicystruct, added in Report Version 5 (SEV FW ABI Rev 1.58) as a mitigation status for the Heracles Attack.There are no functional changes.