validate: change parameters, now accept a full cert chain #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerfanelli
requested changes
Apr 2, 2025
Contributor
Author
|
@tylerfanelli have addressed your comments, please take a look |
tylerfanelli
previously approved these changes
Apr 3, 2025
Member
|
Could you run |
In keeping with the tool's approach, which handles the entire SEV certificate chain, make the same adjustment for the `validate` command: allow the file path to the entire certificate chain instead of just a single file with the PEK certificate, as extracting the PEK alone is not possible with `sevctl`. Signed-off-by: Roman Penyaev <[email protected]>
Contributor
Author
|
@tylerfanelli done |
tylerfanelli
approved these changes
Apr 3, 2025
Member
|
LGTM. @larrydewey @DGonzalezVillal please take a look. |
larrydewey
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In keeping with the tool's approach, which handles the entire SEV certificate chain, make the same adjustment for the
validatecommand: allow the file path to the entire certificate chain instead of just a single file with the PEK certificate, as extracting the PEK alone is not possible withsevctl.Testing this PR should be done in conjunction with the following fixes: virtee/sev#293