Update API #16
Merged
Update API #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jake Correnti <[email protected]>
tylerfanelli
requested changes
Jun 10, 2025
src/launch/mod.rs
Outdated
Comment on lines
227
to
230
| gpa: u64, | ||
| nr_pages: u64, | ||
| attributes: u32, | ||
| source_addr: u64, |
Member
There was a problem hiding this comment.
Suggested change
| gpa: u64, | |
| nr_pages: u64, | |
| attributes: u32, | |
| source_addr: u64, | |
| gpa: u64, | |
| nr_pages: u64, | |
| attributes: u32, | |
| source_addr: u64, |
These could likely be wrapped in their own struct given to the user. See update_data in the sev library.
Update the API to use a `Launcher` type instead of a `TdxVm` and `TdxVcpu`. This is more elegant and is more in line with what virtee/sev is providing users as an interface. Signed-off-by: Jake Correnti <[email protected]>
Update the launch test to use the new `Launcher` API. Signed-off-by: Jake Correnti <[email protected]>
Update Error type to be more idiomatic Rust. Consequently, update error handling where necessary. Signed-off-by: Jake Correnti <[email protected]>
Signed-off-by: Jake Correnti <[email protected]>
tylerfanelli
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the API to be more ergonomic and more idiomatic. The new design is also more in line with what the virtee/sev crate is offering for an interface.
Additionally, update the Error type and handling to be more idiomatic as well.
Resolves: #14