Skip to content

Fix various bugs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tylerfanelli merged 2 commits into from
Nov 24, 2025
Merged

Fix various bugs #20

tylerfanelli merged 2 commits into from
Nov 24, 2025

Conversation

@jakecorrenti
Copy link
Member

@jakecorrenti jakecorrenti commented Nov 21, 2025

  • In the TDVF module, ensure that structs are not just packed, but also #[repr(C)]
  • Dynamically determine the support number of cpuid configs that TDX will report rather than using a hard coded value of 24.

Fixes: #18, #19

@jakecorrenti
Copy link
Member Author

jakecorrenti commented Nov 21, 2025 •
edited
Loading

cc/ @RainaYL

WIP for now while I test it Tested with libkrun and didn't have any issues

@jakecorrenti
launch: support dynamically determining nr_cpuid
5e8d3e6 
Different generations of TDX may report a different number of cpuid
configs. Support determining this number on the fly rather than
hardcoding a value.

Fixes: virtee#18

Signed-off-by: Jake Correnti <[email protected]>
@tylerfanelli tylerfanelli mentioned this pull request Nov 21, 2025
Draft
@jakecorrenti jakecorrenti marked this pull request as ready for review November 21, 2025 21:10
@jakecorrenti jakecorrenti changed the title [WIP] Fix various bugs Fix various bugs Nov 21, 2025
@jakecorrenti jakecorrenti linked an issue Nov 21, 2025 that may be closed by this pull request
Use #[repr(C, packed)] for TDVF-related structs #19
Closed
tylerfanelli
tylerfanelli approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tylerfanelli tylerfanelli merged commit 6819a61 into virtee:main Nov 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylerfanelli tylerfanelli tylerfanelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use #[repr(C, packed)] for TDVF-related structs Increase the buffer size used for get_capabilities

2 participants

@jakecorrenti @tylerfanelli