Fix SynchronousOnlyOperation
error if @paginate
with async view returns Django queryset
#1293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying the
paginate
decorator to an async view that returns a Django queryset, aSynchronousOnlyOperation
error occurs. (cause ofdjango-ninja/ninja/pagination.py
Lines 206 to 208 in 457c066
To resolve this, I've added
_inject_async_pagination
within thepaginate
andRouterPaginated
and differentiated the behavior based on the view type.