Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SynchronousOnlyOperation error if @paginate with async view returns Django queryset #1293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

qodot
Copy link

@qodot qodot commented Sep 8, 2024

When applying the paginate decorator to an async view that returns a Django queryset, a SynchronousOnlyOperation error occurs. (cause of

async def evaluate(results: Union[List, QuerySet]) -> AsyncGenerator:
for result in results:
yield result
)

To resolve this, I've added _inject_async_pagination within the paginate and RouterPaginated and differentiated the behavior based on the view type.

@qodot qodot changed the title Fix SynchronousOnlyOperation error when paginate is used with async views returning Django querysets. Fix SynchronousOnlyOperation error if @paginate with async view returns Django queryset Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant