Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): type hints for hmr events #1886

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Mar 19, 2025

resolve #1885

vitejs/vite@95424b2 の反映です。

Verified

This commit was signed with the committer’s verified signature.
shuuji3 TAKAHASHI Shuuji
resolve vitejs#1885

vitejs/vite@95424b2 の反映です。
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for vitejs-docs-ja failed. Why did it fail? →

Name Link
🔨 Latest commit 23e23c8
🔍 Latest deploy log https://app.netlify.com/sites/vitejs-docs-ja/deploys/67dacda322fd2b000856f3f2

Copy link
Collaborator

@jay-es jay-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
内容は OK ですが CI がエラーになってしまっているので、念のため再プッシュお願いします 🙇

@shuuji3
Copy link
Contributor Author

shuuji3 commented Mar 20, 2025

エラーを詳しく見てみたところ、どうやら元のcommitで追加された新しい型を使おうとしてしまっているのが原因のようでした。現時点では https://github.com/vitejs/vitemainブランチにしか存在しないので、このリポジトリが使用している最新のViteパッケージ (v6.2.2) には含まれていません。次のv6.2.3のリリースまで待つ必要があるかもしれません。

@jay-es
Copy link
Collaborator

jay-es commented Mar 20, 2025

@shuuji3 承知しました!
しばらく待ちましょう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(types): type hints for hmr events
2 participants